Skip to content

Payu setup -r handle empty manifest#707

Merged
Qian-HuiChen merged 2 commits intopayu-org:masterfrom
ACCESS-NRI:704-payu-setup-check
Mar 30, 2026
Merged

Payu setup -r handle empty manifest#707
Qian-HuiChen merged 2 commits intopayu-org:masterfrom
ACCESS-NRI:704-payu-setup-check

Conversation

@Qian-HuiChen
Copy link
Copy Markdown
Collaborator

Closes #704 as part of this payu setup repro check issue.

When manifest is empty (e.g., OM2 initial experiment), payu setup -r does not error immediately. It only errors when a new restart manifests file is created.

@Qian-HuiChen Qian-HuiChen changed the title Payu setup -r handle empty manifest Payu setup -r handle empty manifest Mar 29, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.70%. Comparing base (c37e75c) to head (5c7f176).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
+ Coverage   63.68%   63.70%   +0.01%     
==========================================
  Files          67       67              
  Lines        5557     5554       -3     
==========================================
- Hits         3539     3538       -1     
+ Misses       2018     2016       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Qian-HuiChen Qian-HuiChen requested a review from jo-basevi March 29, 2026 23:46
jo-basevi
jo-basevi previously approved these changes Mar 29, 2026
Copy link
Copy Markdown
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this fix in! I've just had a super quick review

@Qian-HuiChen
Copy link
Copy Markdown
Collaborator Author

Hi @jo-basevi , I am not 100% confident that I understand the issue, or whether my update solve the issue as desired. Please let me know if this is not what we are looking for.

@jo-basevi
Copy link
Copy Markdown
Collaborator

Hi @jo-basevi , I am not 100% confident that I understand the issue, or whether my update solve the issue as desired. Please let me know if this is not what we are looking for.

Removing that check which fails when manifests are empty was the main issue.

We want to be able to run reproduce checks on all files even if one of the manifests is expected to have no files. So for example one way to manually test this would be to get one of the ACCESS-OM2 configurations which cold start (don't start from restarts so has a empty restart manifest), and run payu setup -r. Then to test an expected failure, set restart: /path/to/an/actual/restartN in config.yaml, and run payu setup -r.

Copy link
Copy Markdown
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Qian-HuiChen Qian-HuiChen merged commit d97ecfa into payu-org:master Mar 30, 2026
13 checks passed
@Qian-HuiChen Qian-HuiChen deleted the 704-payu-setup-check branch March 30, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle empty or missing manifests in payu setup --repro

2 participants